From f248ab10815c9b0e6cebd29c6186dd279f5d7feb Mon Sep 17 00:00:00 2001 From: Gergely Hegedus Date: Thu, 27 Jan 2022 02:10:03 +0200 Subject: [PATCH] Issue#13 Fix codeAnalysis errors --- .../test/showcase/testutils/ActivityScenarioExtensions.kt | 4 ++-- .../testutils/MockServerScenarioSetupResetingTestRule.kt | 1 - .../testutils/configuration/SnackbarVerificationHelper.kt | 4 ++-- .../testutils/idling/NetworkSynchronizationTestRule.kt | 1 - .../test/showcase/testutils/idling/awaitIdlingResources.kt | 2 +- .../viewactions/ReplaceProgressBarDrawableToStatic.kt | 2 +- 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/ActivityScenarioExtensions.kt b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/ActivityScenarioExtensions.kt index 345ea86..1bf914c 100644 --- a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/ActivityScenarioExtensions.kt +++ b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/ActivityScenarioExtensions.kt @@ -3,7 +3,7 @@ package org.fnives.test.showcase.testutils import android.app.Activity import androidx.test.core.app.ActivityScenario -fun ActivityScenario.safeClose() { +fun ActivityScenario.safeClose() { workaroundForActivityScenarioCLoseLockingUp() close() } @@ -19,4 +19,4 @@ fun ActivityScenario.safeClose() { */ private fun workaroundForActivityScenarioCLoseLockingUp() { Thread.sleep(1000L) -} \ No newline at end of file +} diff --git a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/MockServerScenarioSetupResetingTestRule.kt b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/MockServerScenarioSetupResetingTestRule.kt index cd1c405..72b48fe 100644 --- a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/MockServerScenarioSetupResetingTestRule.kt +++ b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/MockServerScenarioSetupResetingTestRule.kt @@ -71,7 +71,6 @@ class MockServerScenarioSetupResetingTestRule( .sslSocketFactory(handshakeCertificates.sslSocketFactory(), handshakeCertificates.trustManager) .build() - private fun after() { mockServerScenarioSetup.stop() } diff --git a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/configuration/SnackbarVerificationHelper.kt b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/configuration/SnackbarVerificationHelper.kt index 2520813..0adb1d9 100644 --- a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/configuration/SnackbarVerificationHelper.kt +++ b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/configuration/SnackbarVerificationHelper.kt @@ -11,5 +11,5 @@ interface SnackbarVerificationHelper : TestRule { } @Suppress("TestFunctionName") -fun SnackbarVerificationTestRule(): SnackbarVerificationHelper= - SpecificTestConfigurationsFactory.createSnackbarVerification() \ No newline at end of file +fun SnackbarVerificationTestRule(): SnackbarVerificationHelper = + SpecificTestConfigurationsFactory.createSnackbarVerification() diff --git a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/NetworkSynchronizationTestRule.kt b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/NetworkSynchronizationTestRule.kt index 80c5795..dc97866 100644 --- a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/NetworkSynchronizationTestRule.kt +++ b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/NetworkSynchronizationTestRule.kt @@ -24,7 +24,6 @@ class NetworkSynchronizationTestRule : TestRule, KoinTest { dispose() } } - } } diff --git a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/awaitIdlingResources.kt b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/awaitIdlingResources.kt index b0a1264..21996b5 100644 --- a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/awaitIdlingResources.kt +++ b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/idling/awaitIdlingResources.kt @@ -52,7 +52,7 @@ fun loopMainThreadUntilIdleWithIdlingResources() { } fun loopMainThreadFor(delay: Long) { - if (Looper.getMainLooper().isCurrentThread){ + if (Looper.getMainLooper().isCurrentThread) { Thread.sleep(200L) } else { Espresso.onView(ViewMatchers.isRoot()).perform(LoopMainThreadFor(delay)) diff --git a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/viewactions/ReplaceProgressBarDrawableToStatic.kt b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/viewactions/ReplaceProgressBarDrawableToStatic.kt index b79192e..44a6367 100644 --- a/app/src/sharedTest/java/org/fnives/test/showcase/testutils/viewactions/ReplaceProgressBarDrawableToStatic.kt +++ b/app/src/sharedTest/java/org/fnives/test/showcase/testutils/viewactions/ReplaceProgressBarDrawableToStatic.kt @@ -21,4 +21,4 @@ class ReplaceProgressBarDrawableToStatic : ViewAction { progressBar.indeterminateDrawable = ColorDrawable(Color.GREEN) uiController.loopMainThreadUntilIdle() } -} \ No newline at end of file +}