Issue#67 Fix Code Analysis errors

app/src/androidTest/java/org/fnives/test/showcase/ui/AuthComposeInstrumentedTest.kt

@@ -4,13 +4,13 @@ import androidx.compose.ui.test.junit4.StateRestorationTester
 import androidx.compose.ui.test.junit4.createComposeRule
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import org.fnives.test.showcase.R
+import org.fnives.test.showcase.android.testutil.synchronization.idlingresources.anyResourceIdling
 import org.fnives.test.showcase.compose.screen.AppNavigation
 import org.fnives.test.showcase.core.integration.fake.FakeUserDataLocalStorage
 import org.fnives.test.showcase.core.login.IsUserLoggedInUseCase
 import org.fnives.test.showcase.network.mockserver.scenario.auth.AuthScenario
 import org.fnives.test.showcase.testutils.MockServerScenarioSetupResetingTestRule
 import org.fnives.test.showcase.testutils.idling.DatabaseDispatcherTestRule
-import org.fnives.test.showcase.android.testutil.synchronization.idlingresources.anyResourceIdling
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test

app/src/sharedTest/java/org/fnives/test/showcase/testutils/statesetup/SetupAuthenticationState.kt

@@ -4,10 +4,10 @@ import androidx.lifecycle.Lifecycle
 import androidx.test.core.app.ActivityScenario
 import androidx.test.espresso.intent.Intents
 import androidx.test.runner.intent.IntentStubberRegistry
+import org.fnives.test.showcase.android.testutil.activity.safeClose
 import org.fnives.test.showcase.network.mockserver.MockServerScenarioSetup
 import org.fnives.test.showcase.network.mockserver.scenario.auth.AuthScenario
 import org.fnives.test.showcase.testutils.idling.MainDispatcherTestRule
-import org.fnives.test.showcase.android.testutil.activity.safeClose
 import org.fnives.test.showcase.ui.auth.AuthActivity
 import org.fnives.test.showcase.ui.home.HomeRobot
 import org.fnives.test.showcase.ui.home.MainActivity
@@ -19,7 +19,7 @@ object SetupAuthenticationState : KoinTest {
     fun setupLogin(
         mainDispatcherTestRule: MainDispatcherTestRule,
         mockServerScenarioSetup: MockServerScenarioSetup,
-        resetIntents: Boolean = true
+        resetIntents: Boolean = true,
     ) {
         resetIntentsIfNeeded(resetIntents) {
             mockServerScenarioSetup.setScenario(AuthScenario.Success(username = "a", password = "b"))
@@ -40,7 +40,7 @@ object SetupAuthenticationState : KoinTest {
 
     fun setupLogout(
         mainDispatcherTestRule: MainDispatcherTestRule,
-        resetIntents: Boolean = true
+        resetIntents: Boolean = true,
     ) {
         resetIntentsIfNeeded(resetIntents) {
             val activityScenario = ActivityScenario.launch(MainActivity::class.java)

app/src/sharedTest/java/org/fnives/test/showcase/ui/home/MainActivityInstrumentedTest.kt

@@ -4,6 +4,7 @@ import androidx.test.core.app.ActivityScenario
 import androidx.test.espresso.intent.Intents
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import org.fnives.test.showcase.android.testutil.activity.safeClose
+import org.fnives.test.showcase.android.testutil.synchronization.loopMainThreadFor
 import org.fnives.test.showcase.model.content.FavouriteContent
 import org.fnives.test.showcase.network.mockserver.ContentData
 import org.fnives.test.showcase.network.mockserver.scenario.content.ContentScenario
@@ -11,7 +12,6 @@ import org.fnives.test.showcase.network.mockserver.scenario.refresh.RefreshToken
 import org.fnives.test.showcase.testutils.MockServerScenarioSetupResetingTestRule
 import org.fnives.test.showcase.testutils.idling.AsyncDiffUtilInstantTestRule
 import org.fnives.test.showcase.testutils.idling.MainDispatcherTestRule
-import org.fnives.test.showcase.android.testutil.synchronization.loopMainThreadFor
 import org.fnives.test.showcase.testutils.statesetup.SetupAuthenticationState.setupLogin
 import org.junit.After
 import org.junit.Before

app/src/sharedTest/java/org/fnives/test/showcase/ui/login/AuthActivityInstrumentedTest.kt

@@ -4,10 +4,10 @@ import androidx.test.core.app.ActivityScenario
 import androidx.test.espresso.intent.Intents
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import org.fnives.test.showcase.R
+import org.fnives.test.showcase.android.testutil.activity.safeClose
 import org.fnives.test.showcase.network.mockserver.scenario.auth.AuthScenario
 import org.fnives.test.showcase.testutils.MockServerScenarioSetupResetingTestRule
 import org.fnives.test.showcase.testutils.idling.MainDispatcherTestRule
-import org.fnives.test.showcase.android.testutil.activity.safeClose
 import org.fnives.test.showcase.ui.auth.AuthActivity
 import org.junit.After
 import org.junit.Before

app/src/sharedTest/java/org/fnives/test/showcase/ui/login/codekata/CodeKataSharedRobotTest.kt

@@ -8,9 +8,9 @@ import androidx.test.espresso.intent.Intents
 import androidx.test.espresso.intent.matcher.IntentMatchers
 import androidx.test.espresso.matcher.ViewMatchers
 import org.fnives.test.showcase.R
+import org.fnives.test.showcase.android.testutil.intent.notIntended
 import org.fnives.test.showcase.android.testutil.snackbar.SnackbarVerificationHelper.assertSnackBarIsNotShown
 import org.fnives.test.showcase.android.testutil.snackbar.SnackbarVerificationHelper.assertSnackBarIsShownWithText
-import org.fnives.test.showcase.android.testutil.intent.notIntended
 import org.fnives.test.showcase.ui.home.MainActivity
 import org.hamcrest.core.IsNot
 

app/src/sharedTest/java/org/fnives/test/showcase/ui/splash/SplashActivityInstrumentedTest.kt

@@ -4,9 +4,9 @@ import androidx.lifecycle.Lifecycle
 import androidx.test.core.app.ActivityScenario
 import androidx.test.espresso.intent.Intents
 import androidx.test.ext.junit.runners.AndroidJUnit4
+import org.fnives.test.showcase.android.testutil.activity.safeClose
 import org.fnives.test.showcase.testutils.MockServerScenarioSetupResetingTestRule
 import org.fnives.test.showcase.testutils.idling.MainDispatcherTestRule
-import org.fnives.test.showcase.android.testutil.activity.safeClose
 import org.fnives.test.showcase.testutils.statesetup.SetupAuthenticationState.setupLogin
 import org.fnives.test.showcase.testutils.statesetup.SetupAuthenticationState.setupLogout
 import org.junit.After

app/src/test/java/org/fnives/test/showcase/ui/auth/AuthViewModelTest.kt

@@ -44,6 +44,11 @@ internal class AuthViewModelTest {
     @DisplayName("GIVEN initialized viewModel WHEN observed THEN loading false other fields are empty")
     @Test
     fun initialSetup() {
+        var a = ""
+        repeat(1200 / 2) {
+            a += "a "
+        }
+        System.err.println(a+"b")
         val usernameTestObserver = sut.username.test()
         val passwordTestObserver = sut.password.test()
         val loadingTestObserver = sut.loading.test()

gradlescripts/testdependencies.gradle

@@ -49,7 +49,7 @@ project.ext {
     def testing_json_assert_version = propertyOrNull('json_assert_version') ?: "1.5.0"
     def testing_okhttp3 = propertyOrNull('okhttp_version') ?: "4.9.3"
     def testing_turbine_version = propertyOrNull('turbine_version') ?: "0.7.0"
-    def testing_androidx_room_version = propertyOrNull('room_version') ?: "2.4.1"
+    def testing_androidx_room_version = propertyOrNull('room_version') ?: "2.4.2"
     def testing_livedata_version = propertyOrNull('testing_livedata_version') ?: "1.2.0"
     def testing_compose_version = propertyOrNull('compose_version') ?: "1.1.0"
     def testing_hamcrest_version = propertyOrNull('hamcrest_version')?: "2.2"

gradlescripts/versions.gradle

@@ -5,7 +5,7 @@ project.ext {
     androidx_constraintlayout_version = "2.1.3"
     androidx_livedata_version = "2.4.0"
     androidx_swiperefreshlayout_version = "1.1.0"
-    room_version = "2.4.1"
+    room_version = "2.4.2"
     activity_ktx_version = "1.4.0"
     androidx_navigation = "2.4.0"
 

test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/intent/notIntended.kt

@@ -5,6 +5,7 @@ import androidx.test.espresso.intent.Intents.intended
 import org.hamcrest.Matcher
 import org.hamcrest.StringDescription
 
+@Suppress("SwallowedException")
 fun notIntended(matcher: Matcher<Intent>) {
     try {
         intended(matcher)

test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/snackbar/SnackbarVerificationHelper.kt

@@ -9,10 +9,10 @@ import androidx.test.espresso.ViewAction
 import androidx.test.espresso.action.ViewActions
 import androidx.test.espresso.assertion.ViewAssertions
 import androidx.test.espresso.matcher.ViewMatchers
-import com.google.android.material.R as MaterialR
 import com.google.android.material.snackbar.Snackbar
 import org.hamcrest.Matcher
 import org.hamcrest.Matchers
+import com.google.android.material.R as MaterialR
 
 object SnackbarVerificationHelper {
 
@@ -41,4 +41,4 @@ object SnackbarVerificationHelper {
             }
         }
     }
-}
+}

test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/synchronization/mainThreadSynchronization.kt

@@ -32,4 +32,4 @@ fun loopMainThreadFor(delay: Long) {
     } else {
         Espresso.onView(ViewMatchers.isRoot()).perform(LoopMainThreadFor(delay))
     }
-}
+}

test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/viewaction/LoopMainThreadFor.kt

@@ -14,4 +14,4 @@ class LoopMainThreadFor(private val delayInMillis: Long) : ViewAction {
     override fun perform(uiController: UiController, view: View?) {
         uiController.loopMainThreadForAtLeast(delayInMillis)
     }
-}
+}

test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/viewaction/LoopMainThreadUntilIdle.kt

@@ -14,4 +14,4 @@ class LoopMainThreadUntilIdle : ViewAction {
     override fun perform(uiController: UiController, view: View?) {
         uiController.loopMainThreadUntilIdle()
     }
-}
+}

test-util-shared-robolectric/src/main/java/org/fnives/test/showcase/android/testutil/SharedMigrationTestRule.kt

@@ -26,4 +26,4 @@ interface SharedMigrationTestRule : TestRule {
 
     fun closeWhenFinished(db: SupportSQLiteDatabase)
     fun closeWhenFinished(db: RoomDatabase)
-}
+}

test-util-shared-robolectric/src/main/java/org/fnives/test/showcase/android/testutil/SharedMigrationTestRuleFactory.kt

@@ -6,8 +6,8 @@ import androidx.room.migration.AutoMigrationSpec
 import androidx.sqlite.db.SupportSQLiteOpenHelper
 import org.fnives.test.showcase.android.testutil.robolectric.RobolectricMigrationTestRule
 
-inline fun <reified Database: RoomDatabase> SharedMigrationTestRule(
+inline fun <reified Database : RoomDatabase> SharedMigrationTestRule(
-    instrumentation: Instrumentation
+    instrumentation: Instrumentation,
 ): SharedMigrationTestRule =
     createAndroidClassOrRobolectric(
         androidClassFactory = { androidClass ->
@@ -22,9 +22,9 @@ inline fun <reified Database: RoomDatabase> SharedMigrationTestRule(
         }
     )
 
-inline fun <reified Database: RoomDatabase> SharedMigrationTestRule(
+inline fun <reified Database : RoomDatabase> SharedMigrationTestRule(
     instrumentation: Instrumentation,
-    specs: List<AutoMigrationSpec>
+    specs: List<AutoMigrationSpec>,
 ): SharedMigrationTestRule =
     createAndroidClassOrRobolectric(
         androidClassFactory = { androidClass ->
@@ -40,10 +40,10 @@ inline fun <reified Database: RoomDatabase> SharedMigrationTestRule(
         }
     )
 
-inline fun <reified Database: RoomDatabase> SharedMigrationTestRule(
+inline fun <reified Database : RoomDatabase> SharedMigrationTestRule(
     instrumentation: Instrumentation,
     specs: List<AutoMigrationSpec>,
-    openFactory: SupportSQLiteOpenHelper.Factory
+    openFactory: SupportSQLiteOpenHelper.Factory,
 ): SharedMigrationTestRule =
     createAndroidClassOrRobolectric(
         androidClassFactory = { androidClass ->
@@ -62,7 +62,7 @@ inline fun <reified Database: RoomDatabase> SharedMigrationTestRule(
 
 fun createAndroidClassOrRobolectric(
     androidClassFactory: (Class<*>) -> Any,
-    robolectricFactory: () -> SharedMigrationTestRule
+    robolectricFactory: () -> SharedMigrationTestRule,
 ): SharedMigrationTestRule {
     val androidClass = getAndroidClass()
     return if (androidClass == null) {
@@ -72,8 +72,9 @@ fun createAndroidClassOrRobolectric(
     }
 }
 
+@Suppress("SwallowedException")
 private fun getAndroidClass() = try {
     Class.forName("org.fnives.test.showcase.android.testutil.AndroidMigrationTestRule")
 } catch (classNotFoundException: ClassNotFoundException) {
     null
-}
+}