diff --git a/app-shared-test/src/main/java/org/fnives/test/showcase/storage/migration/MigrationToLatestInstrumentedSharedTest.kt b/app-shared-test/src/main/java/org/fnives/test/showcase/storage/migration/MigrationToLatestInstrumentedSharedTest.kt index 3c24451..7dbc095 100644 --- a/app-shared-test/src/main/java/org/fnives/test/showcase/storage/migration/MigrationToLatestInstrumentedSharedTest.kt +++ b/app-shared-test/src/main/java/org/fnives/test/showcase/storage/migration/MigrationToLatestInstrumentedSharedTest.kt @@ -24,7 +24,7 @@ import java.io.IOException * https://developer.android.com/training/data-storage/room/migrating-db-versions */ @RunWith(AndroidJUnit4::class) -open class MigrationToLatestInstrumentedSharedTest : KoinTest { +abstract class MigrationToLatestInstrumentedSharedTest : KoinTest { @get:Rule val helper = SharedMigrationTestRule(instrumentation = InstrumentationRegistry.getInstrumentation()) diff --git a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/home/MainActivityInstrumentedSharedTest.kt b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/home/MainActivityInstrumentedSharedTest.kt index 798c9e7..e3fd1c2 100644 --- a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/home/MainActivityInstrumentedSharedTest.kt +++ b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/home/MainActivityInstrumentedSharedTest.kt @@ -23,7 +23,7 @@ import org.junit.rules.RuleChain import org.koin.test.KoinTest @Suppress("TestFunctionName") -open class MainActivityInstrumentedSharedTest : KoinTest { +abstract class MainActivityInstrumentedSharedTest : KoinTest { private lateinit var activityScenario: ActivityScenario diff --git a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/AuthActivityInstrumentedSharedTest.kt b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/AuthActivityInstrumentedSharedTest.kt index 36725e5..99ba24f 100644 --- a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/AuthActivityInstrumentedSharedTest.kt +++ b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/AuthActivityInstrumentedSharedTest.kt @@ -18,7 +18,7 @@ import org.junit.rules.RuleChain import org.koin.test.KoinTest @Suppress("TestFunctionName") -open class AuthActivityInstrumentedSharedTest : KoinTest { +abstract class AuthActivityInstrumentedSharedTest : KoinTest { private lateinit var activityScenario: ActivityScenario diff --git a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/codekata/CodeKataAuthActivitySharedTest.kt b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/codekata/CodeKataAuthActivitySharedTest.kt index 07b66a0..eb94e63 100644 --- a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/codekata/CodeKataAuthActivitySharedTest.kt +++ b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/login/codekata/CodeKataAuthActivitySharedTest.kt @@ -14,7 +14,7 @@ import org.koin.test.KoinTest @OptIn(ExperimentalCoroutinesApi::class) @Ignore("CodeKata") @Suppress("EmptyFunctionBlock") -open class CodeKataAuthActivitySharedTest : KoinTest { +abstract class CodeKataAuthActivitySharedTest : KoinTest { @Before fun setup() { diff --git a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/splash/SplashActivityInstrumentedSharedTest.kt b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/splash/SplashActivityInstrumentedSharedTest.kt index f08761a..fbdde66 100644 --- a/app-shared-test/src/main/java/org/fnives/test/showcase/ui/splash/SplashActivityInstrumentedSharedTest.kt +++ b/app-shared-test/src/main/java/org/fnives/test/showcase/ui/splash/SplashActivityInstrumentedSharedTest.kt @@ -18,7 +18,7 @@ import org.junit.rules.RuleChain import org.koin.test.KoinTest @Suppress("TestFunctionName") -open class SplashActivityInstrumentedSharedTest : KoinTest { +abstract class SplashActivityInstrumentedSharedTest : KoinTest { private lateinit var activityScenario: ActivityScenario diff --git a/codekata/sharedtests.instructionset.md b/codekata/sharedtests.instructionset.md index 5bbb35c..b251e5b 100644 --- a/codekata/sharedtests.instructionset.md +++ b/codekata/sharedtests.instructionset.md @@ -39,7 +39,7 @@ Let's open `org.fnives.test.showcase.ui.login.codekata.CodeKataAuthActivityShare We can see it's identical as our original `org.fnives.test.showcase.ui.codekata.CodeKataAuthActivityInstrumentedTest`. So let's copy our existing code from the Robolectric test here. For that we can use the body of `org.fnives.test.showcase.ui.RobolectricAuthActivityInstrumentedTest`. -Of course keep the `open` and the `CodeKataAuthActivitySharedTest` class name and package. +Of course keep the `abstract`, the `CodeKataAuthActivitySharedTest` class name and package. We need to modify our robot: ```kotlin // Instead of this: diff --git a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/storage/migration/MigrationToLatestInstrumentedSharedTest.kt b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/storage/migration/MigrationToLatestInstrumentedSharedTest.kt index da60724..2f60e68 100644 --- a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/storage/migration/MigrationToLatestInstrumentedSharedTest.kt +++ b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/storage/migration/MigrationToLatestInstrumentedSharedTest.kt @@ -21,7 +21,8 @@ import java.io.IOException * https://developer.android.com/training/data-storage/room/migrating-db-versions */ @RunWith(AndroidJUnit4::class) -open class MigrationToLatestInstrumentedSharedTest { +@Suppress("UnnecessaryAbstractClass") +abstract class MigrationToLatestInstrumentedSharedTest { @get:Rule val helper = SharedMigrationTestRule(instrumentation = InstrumentationRegistry.getInstrumentation()) diff --git a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/NetworkSynchronizedActivityTest.kt b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/NetworkSynchronizedActivityTest.kt index ac61133..79b4679 100644 --- a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/NetworkSynchronizedActivityTest.kt +++ b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/NetworkSynchronizedActivityTest.kt @@ -7,7 +7,8 @@ import org.junit.Before import org.junit.Rule import javax.inject.Inject -open class NetworkSynchronizedActivityTest { +@Suppress("UnnecessaryAbstractClass") +abstract class NetworkSynchronizedActivityTest { @Inject lateinit var networkSynchronizationHelper: NetworkSynchronizationHelper diff --git a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/auth/AuthActivityInstrumentedSharedTest.kt b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/auth/AuthActivityInstrumentedSharedTest.kt index f9b7327..aa7ce34 100644 --- a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/auth/AuthActivityInstrumentedSharedTest.kt +++ b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/auth/AuthActivityInstrumentedSharedTest.kt @@ -17,7 +17,7 @@ import org.junit.Test import org.junit.rules.RuleChain @Suppress("TestFunctionName") -open class AuthActivityInstrumentedSharedTest : NetworkSynchronizedActivityTest() { +abstract class AuthActivityInstrumentedSharedTest : NetworkSynchronizedActivityTest() { private lateinit var activityScenario: ActivityScenario diff --git a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/home/MainActivityInstrumentedSharedTest.kt b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/home/MainActivityInstrumentedSharedTest.kt index 128f468..c340211 100644 --- a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/home/MainActivityInstrumentedSharedTest.kt +++ b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/home/MainActivityInstrumentedSharedTest.kt @@ -23,7 +23,7 @@ import org.junit.Test import org.junit.rules.RuleChain @Suppress("TestFunctionName") -open class MainActivityInstrumentedSharedTest : NetworkSynchronizedActivityTest() { +abstract class MainActivityInstrumentedSharedTest : NetworkSynchronizedActivityTest() { private lateinit var activityScenario: ActivityScenario diff --git a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/splash/SplashActivityInstrumentedSharedTest.kt b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/splash/SplashActivityInstrumentedSharedTest.kt index aeadbaa..3446238 100644 --- a/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/splash/SplashActivityInstrumentedSharedTest.kt +++ b/hilt/hilt-app-shared-test/src/main/java/org/fnives/test/showcase/hilt/test/shared/ui/splash/SplashActivityInstrumentedSharedTest.kt @@ -18,7 +18,7 @@ import org.junit.Test import org.junit.rules.RuleChain @Suppress("TestFunctionName") -open class SplashActivityInstrumentedSharedTest : NetworkSynchronizedActivityTest() { +abstract class SplashActivityInstrumentedSharedTest : NetworkSynchronizedActivityTest() { private lateinit var activityScenario: ActivityScenario