Fix code analysis errors
With that updated Mockito, so `verifyZeroInteractions` is now `verifyNoInteractions`
This commit is contained in:
parent
1d2ca90203
commit
58a76a3d28
18 changed files with 71 additions and 69 deletions
|
|
@ -162,7 +162,7 @@ fun withoutSessionTheUserIsNotLoggedIn() = runTest {
|
|||
val actual = isUserLoggedInUseCase.invoke()
|
||||
|
||||
Assertions.assertFalse(actual, "User is expected to be not logged in")
|
||||
verifyZeroInteractions(mockSessionExpirationListener)
|
||||
verifyNoInteractions(mockSessionExpirationListener)
|
||||
}
|
||||
```
|
||||
|
||||
|
|
@ -187,7 +187,7 @@ And just verify:
|
|||
Assertions.assertEquals(Answer.Success(LoginStatus.SUCCESS), answer)
|
||||
Assertions.assertTrue(actual, "User is expected to be logged in")
|
||||
Assertions.assertEquals(expectedSession, fakeUserDataLocalStorage.session)
|
||||
verifyZeroInteractions(mockSessionExpirationListener)
|
||||
verifyNoInteractions(mockSessionExpirationListener)
|
||||
```
|
||||
|
||||
With this, looks like our Integration works correctly. Requests are called, proper response is received, login state is changed.
|
||||
|
|
@ -214,7 +214,7 @@ And do our verifications, aka not logged in, not session expired and the correct
|
|||
Assertions.assertEquals(Answer.Success(loginError), answer)
|
||||
Assertions.assertFalse(actual, "User is expected to be not logged in")
|
||||
Assertions.assertEquals(null, fakeUserDataLocalStorage.session)
|
||||
verifyZeroInteractions(mockSessionExpirationListener)
|
||||
verifyNoInteractions(mockSessionExpirationListener)
|
||||
```
|
||||
|
||||
Now we just need to declare our parameters for our test:
|
||||
|
|
@ -247,7 +247,7 @@ fun networkInputError(authScenario: AuthScenario) = runTest {
|
|||
Assertions.assertTrue(answer is Answer.Error, "Answer is expected to be an Error")
|
||||
Assertions.assertFalse(actual, "User is expected to be not logged in")
|
||||
Assertions.assertEquals(null, fakeUserDataLocalStorage.session)
|
||||
verifyZeroInteractions(mockSessionExpirationListener)
|
||||
verifyNoInteractions(mockSessionExpirationListener)
|
||||
}
|
||||
|
||||
//...
|
||||
|
|
@ -282,7 +282,7 @@ fun loginInvalidCredentials() = runTest {
|
|||
Assertions.assertEquals(Answer.Success(LoginStatus.INVALID_CREDENTIALS), answer)
|
||||
Assertions.assertFalse(actual, "User is expected to be not logged in")
|
||||
Assertions.assertEquals(null, fakeUserDataLocalStorage.session)
|
||||
verifyZeroInteractions(mockSessionExpirationListener)
|
||||
verifyNoInteractions(mockSessionExpirationListener)
|
||||
}
|
||||
```
|
||||
|
||||
|
|
@ -305,7 +305,7 @@ And we verify the user is indeed logged out now:
|
|||
```kotlin
|
||||
Assertions.assertFalse(actual, "User is expected to be logged out")
|
||||
Assertions.assertEquals(null, fakeUserDataLocalStorage.session)
|
||||
verifyZeroInteractions(mockSessionExpirationListener)
|
||||
verifyNoInteractions(mockSessionExpirationListener)
|
||||
```
|
||||
|
||||
### 7. `logoutReleasesContent`
|
||||
|
|
|
|||
|
|
@ -56,7 +56,7 @@ When the class is created, the delegate should not yet be touched, so we start t
|
|||
@DisplayName("WHEN nothing is changed THEN delegate is not touched") // this will show up when running our tests and is a great way to document what we are testing
|
||||
@Test // this defines that this method is a test, needs to be org.junit.jupiter.api.Test
|
||||
fun verifyNoInteractionsIfNoInvocations() {
|
||||
verifyZeroInteractions(mockSessionExpirationListener) // we verify that our mock object's functions / properties have not been touched
|
||||
verifyNoInteractions(mockSessionExpirationListener) // we verify that our mock object's functions / properties have not been touched
|
||||
}
|
||||
```
|
||||
|
||||
|
|
@ -131,8 +131,8 @@ Lastly we add verification:
|
|||
|
||||
```kotlin
|
||||
Assertions.assertEquals(expected, actual) // assert the result is what we expected
|
||||
verifyZeroInteractions(mockLoginRemoteSource) // assert no request was called
|
||||
verifyZeroInteractions(mockUserDataLocalStorage) // assert we didn't modify our storage
|
||||
verifyNoInteractions(mockLoginRemoteSource) // assert no request was called
|
||||
verifyNoInteractions(mockUserDataLocalStorage) // assert we didn't modify our storage
|
||||
```
|
||||
|
||||
But something is wrong, the invoke method cannot be executed since it's a suspending function.
|
||||
|
|
@ -148,8 +148,8 @@ fun emptyUserNameReturnsLoginStatusError() = runTest {
|
|||
val actual = sut.invoke(LoginCredentials("", "a"))
|
||||
|
||||
Assertions.assertEquals(expected, actual)
|
||||
verifyZeroInteractions(mockLoginRemoteSource)
|
||||
verifyZeroInteractions(mockUserDataLocalStorage)
|
||||
verifyNoInteractions(mockLoginRemoteSource)
|
||||
verifyNoInteractions(mockUserDataLocalStorage)
|
||||
}
|
||||
```
|
||||
|
||||
|
|
@ -172,8 +172,8 @@ fun emptyPasswordNameReturnsLoginStatusError() = runTest {
|
|||
val actual = sut.invoke(LoginCredentials("a", ""))
|
||||
|
||||
Assertions.assertEquals(expected, actual)
|
||||
verifyZeroInteractions(mockLoginRemoteSource)
|
||||
verifyZeroInteractions(mockUserDataLocalStorage)
|
||||
verifyNoInteractions(mockLoginRemoteSource)
|
||||
verifyNoInteractions(mockUserDataLocalStorage)
|
||||
}
|
||||
```
|
||||
|
||||
|
|
@ -211,7 +211,7 @@ And finally verification:
|
|||
|
||||
```kotlin
|
||||
Assertions.assertEquals(expected, actual)
|
||||
verifyZeroInteractions(mockUserDataLocalStorage)
|
||||
verifyNoInteractions(mockUserDataLocalStorage)
|
||||
```
|
||||
|
||||
Together:
|
||||
|
|
@ -226,7 +226,7 @@ fun invalidLoginResponseReturnInvalidCredentials() = runTest {
|
|||
val actual = sut.invoke(LoginCredentials("a", "b"))
|
||||
|
||||
Assertions.assertEquals(expected, actual)
|
||||
verifyZeroInteractions(mockUserDataLocalStorage)
|
||||
verifyNoInteractions(mockUserDataLocalStorage)
|
||||
}
|
||||
```
|
||||
|
||||
|
|
@ -291,7 +291,7 @@ Verification:
|
|||
|
||||
```kotlin
|
||||
Assertions.assertEquals(expected, actual)
|
||||
verifyZeroInteractions(mockUserDataLocalStorage)
|
||||
verifyNoInteractions(mockUserDataLocalStorage)
|
||||
```
|
||||
|
||||
Together:
|
||||
|
|
@ -308,7 +308,7 @@ fun invalidResponseResultsInErrorReturned() = runTest {
|
|||
val actual = sut.invoke(LoginCredentials("a", "b"))
|
||||
|
||||
Assertions.assertEquals(expected, actual)
|
||||
verifyZeroInteractions(mockUserDataLocalStorage)
|
||||
verifyNoInteractions(mockUserDataLocalStorage)
|
||||
}
|
||||
```
|
||||
#### Lessons learned
|
||||
|
|
|
|||
|
|
@ -328,7 +328,7 @@ Assertions.assertEquals("login-access", contentRequestAfterRefreshed.getHeader("
|
|||
// this matches the data from the success_response_login.json
|
||||
val expectedSavedSession = Session(accessToken = "login-access", refreshToken = "login-refresh")
|
||||
verify(mockNetworkSessionLocalStorage, times(1)).session = expectedSavedSession
|
||||
verifyZeroInteractions(mockNetworkSessionExpirationListener)
|
||||
verifyNoInteractions(mockNetworkSessionExpirationListener)
|
||||
```
|
||||
|
||||
### 2. `failingRefreshResultsInSessionExpiration`
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue