Add pipeline: codeAnalysis, tests and clean up gradle

network/src/test/java/org/fnives/test/showcase/network/auth/CodeKataLoginRemoteSourceTest.kt

@@ -1,24 +1,11 @@
 package org.fnives.test.showcase.network.auth
 
 import kotlinx.coroutines.runBlocking
-import okhttp3.mockwebserver.MockResponse
-import okhttp3.mockwebserver.MockWebServer
-import org.fnives.test.showcase.model.auth.LoginCredentials
-import org.fnives.test.showcase.model.network.BaseUrl
-import org.fnives.test.showcase.model.session.Session
-import org.fnives.test.showcase.network.auth.model.LoginStatusResponses
-import org.fnives.test.showcase.network.di.createNetworkModules
-import org.fnives.test.showcase.network.session.NetworkSessionLocalStorage
-import org.fnives.test.showcase.network.shared.exceptions.NetworkException
-import org.fnives.test.showcase.network.shared.exceptions.ParsingException
-import org.junit.jupiter.api.*
-import org.koin.core.context.startKoin
-import org.koin.core.context.stopKoin
-import org.koin.test.KoinTest
-import org.koin.test.inject
-import org.mockito.kotlin.mock
-import org.skyscreamer.jsonassert.JSONAssert
-import org.skyscreamer.jsonassert.JSONCompareMode
+import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
 import java.io.BufferedReader
 import java.io.InputStreamReader
 
@@ -27,54 +14,46 @@ class CodeKataLoginRemoteSourceTest {
 
     @BeforeEach
     fun setUp() {
-
     }
 
     @AfterEach
     fun tearDown() {
-
     }
 
     @DisplayName("GIVEN successful response WHEN request is fired THEN login status success is returned")
     @Test
     fun successResponseIsParsedProperly() = runBlocking {
-
     }
 
     @DisplayName("GIVEN successful response WHEN request is fired THEN the request is setup properly")
     @Test
     fun requestProperlySetup() = runBlocking {
-
     }
 
     @DisplayName("GIVEN bad request response WHEN request is fired THEN login status invalid credentials is returned")
     @Test
     fun badRequestMeansInvalidCredentials() = runBlocking {
-
     }
 
     @DisplayName("GIVEN_internal_error_response_WHEN_request_is_fired_THEN_network_exception_is_thrown")
     @Test
     fun genericErrorMeansNetworkError() {
-
     }
 
     @DisplayName("GIVEN invalid json response WHEN request is fired THEN network exception is thrown")
     @Test
     fun invalidJsonMeansParsingException() {
-
     }
 
     @DisplayName("GIVEN malformed json response WHEN request is fired THEN network exception is thrown")
     @Test
     fun malformedJsonMeansParsingException() {
-
     }
 
     companion object {
         internal fun Any.readResourceFile(filePath: String): String = try {
             BufferedReader(InputStreamReader(this.javaClass.classLoader.getResourceAsStream(filePath)!!))
-                    .readLines().joinToString("\n")
+                .readLines().joinToString("\n")
         } catch (nullPointerException: NullPointerException) {
             throw IllegalArgumentException("$filePath file not found!", nullPointerException)
         }
@@ -87,6 +66,5 @@ class CodeKataLoginRemoteSourceTest {
                 } while (true)
             }
         }
-
     }
-}
+}

network/src/test/java/org/fnives/test/showcase/network/auth/LoginRemoteSourceTest.kt

@@ -12,7 +12,11 @@ import org.fnives.test.showcase.network.session.NetworkSessionLocalStorage
 import org.fnives.test.showcase.network.shared.MockServerScenarioSetupExtensions
 import org.fnives.test.showcase.network.shared.exceptions.NetworkException
 import org.fnives.test.showcase.network.shared.exceptions.ParsingException
-import org.junit.jupiter.api.*
+import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.RegisterExtension
 import org.koin.core.context.startKoin
 import org.koin.core.context.stopKoin
@@ -26,6 +30,7 @@ import org.skyscreamer.jsonassert.JSONCompareMode
 class LoginRemoteSourceTest : KoinTest {
 
     private val sut by inject<LoginRemoteSource>()
+
     @RegisterExtension
     @JvmField
     val mockServerScenarioSetupExtensions = MockServerScenarioSetupExtensions()
@@ -76,7 +81,11 @@ class LoginRemoteSourceTest : KoinTest {
         Assertions.assertEquals(null, request.getHeader("Authorization"))
         Assertions.assertEquals("/login", request.path)
         val loginRequest = createExpectedLoginRequestJson("a", "b")
-        JSONAssert.assertEquals(loginRequest, request.body.readUtf8(), JSONCompareMode.NON_EXTENSIBLE)
+        JSONAssert.assertEquals(
+            loginRequest,
+            request.body.readUtf8(),
+            JSONCompareMode.NON_EXTENSIBLE
+        )
     }
 
     @DisplayName("GIVEN bad request response WHEN request is fired THEN login status invalid credentials is returned")

network/src/test/java/org/fnives/test/showcase/network/content/CodeKataSessionExpirationTest.kt

@@ -1,21 +1,21 @@
 package org.fnives.test.showcase.network.content
 
 import kotlinx.coroutines.runBlocking
-import okhttp3.mockwebserver.MockResponse
 import okhttp3.mockwebserver.MockWebServer
 import org.fnives.test.showcase.model.network.BaseUrl
-import org.fnives.test.showcase.model.session.Session
-import org.fnives.test.showcase.network.auth.CodeKataLoginRemoteSourceTest.Companion.readResourceFile
 import org.fnives.test.showcase.network.di.createNetworkModules
 import org.fnives.test.showcase.network.session.NetworkSessionExpirationListener
 import org.fnives.test.showcase.network.session.NetworkSessionLocalStorage
-import org.fnives.test.showcase.network.shared.exceptions.NetworkException
-import org.junit.jupiter.api.*
+import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
 import org.koin.core.context.startKoin
 import org.koin.core.context.stopKoin
 import org.koin.test.KoinTest
 import org.koin.test.inject
-import org.mockito.kotlin.*
+import org.mockito.kotlin.mock
 
 @Disabled("CodeKata")
 class CodeKataSessionExpirationTest : KoinTest {
@@ -33,12 +33,12 @@ class CodeKataSessionExpirationTest : KoinTest {
         mockNetworkSessionExpirationListener = mock()
         startKoin {
             modules(
-                    createNetworkModules(
-                            baseUrl = BaseUrl(mockWebServer.url("mockserver/").toString()),
-                            enableLogging = true,
-                            networkSessionExpirationListenerProvider = { mockNetworkSessionExpirationListener },
-                            networkSessionLocalStorageProvider = { mockNetworkSessionLocalStorage }
-                    ).toList()
+                createNetworkModules(
+                    baseUrl = BaseUrl(mockWebServer.url("mockserver/").toString()),
+                    enableLogging = true,
+                    networkSessionExpirationListenerProvider = { mockNetworkSessionExpirationListener },
+                    networkSessionLocalStorageProvider = { mockNetworkSessionLocalStorage }
+                ).toList()
             )
         }
     }
@@ -57,6 +57,5 @@ class CodeKataSessionExpirationTest : KoinTest {
     @DisplayName("GIVEN 401 THEN failing refresh WHEN content requested THE error is returned and callback is Called")
     @Test
     fun failingRefreshResultsInSessionExpiration() = runBlocking {
-
     }
-}
+}

network/src/test/java/org/fnives/test/showcase/network/content/SessionExpirationTest.kt

@@ -11,7 +11,11 @@ import org.fnives.test.showcase.network.session.NetworkSessionExpirationListener
 import org.fnives.test.showcase.network.session.NetworkSessionLocalStorage
 import org.fnives.test.showcase.network.shared.MockServerScenarioSetupExtensions
 import org.fnives.test.showcase.network.shared.exceptions.NetworkException
-import org.junit.jupiter.api.*
+import org.junit.jupiter.api.AfterEach
+import org.junit.jupiter.api.Assertions
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.DisplayName
+import org.junit.jupiter.api.Test
 import org.junit.jupiter.api.extension.RegisterExtension
 import org.koin.core.context.startKoin
 import org.koin.core.context.stopKoin
@@ -64,35 +68,39 @@ class SessionExpirationTest : KoinTest {
     @DisplayName("GIVEN_401_THEN_refresh_token_ok_response_WHEN_content_requested_THE_tokens_are_refreshed_and_request_retried_with_new_tokens")
     @Test
     fun successRefreshResultsInRequestRetry() = runBlocking {
-            var sessionToReturnByMock: Session? = ContentData.loginSuccessResponse
-            mockServerScenarioSetup.setScenario(
-                ContentScenario.Unauthorized(false)
-                    .then(ContentScenario.Success(true)),
-                false
-            )
-            mockServerScenarioSetup.setScenario(RefreshTokenScenario.Success, false)
-            whenever(mockNetworkSessionLocalStorage.session).doAnswer { sessionToReturnByMock }
-            doAnswer { sessionToReturnByMock = it.arguments[0] as Session? }
-                .whenever(mockNetworkSessionLocalStorage).session = anyOrNull()
+        var sessionToReturnByMock: Session? = ContentData.loginSuccessResponse
+        mockServerScenarioSetup.setScenario(
+            ContentScenario.Unauthorized(false)
+                .then(ContentScenario.Success(true)),
+            false
+        )
+        mockServerScenarioSetup.setScenario(RefreshTokenScenario.Success, false)
+        whenever(mockNetworkSessionLocalStorage.session).doAnswer { sessionToReturnByMock }
+        doAnswer { sessionToReturnByMock = it.arguments[0] as Session? }
+            .whenever(mockNetworkSessionLocalStorage).session = anyOrNull()
 
-            sut.get()
+        sut.get()
 
-            mockServerScenarioSetup.takeRequest()
-            val refreshRequest = mockServerScenarioSetup.takeRequest()
-            val retryAfterTokenRefreshRequest = mockServerScenarioSetup.takeRequest()
+        mockServerScenarioSetup.takeRequest()
+        val refreshRequest = mockServerScenarioSetup.takeRequest()
+        val retryAfterTokenRefreshRequest = mockServerScenarioSetup.takeRequest()
 
-            Assertions.assertEquals("PUT", refreshRequest.method)
-            Assertions.assertEquals("/login/${ContentData.loginSuccessResponse.refreshToken}", refreshRequest.path)
-            Assertions.assertEquals(null, refreshRequest.getHeader("Authorization"))
-            Assertions.assertEquals("Android", refreshRequest.getHeader("Platform"))
-            Assertions.assertEquals("", refreshRequest.body.readUtf8())
-            Assertions.assertEquals(
-                ContentData.refreshSuccessResponse.accessToken,
-                retryAfterTokenRefreshRequest.getHeader("Authorization")
-            )
-            verify(mockNetworkSessionLocalStorage, times(1)).session = ContentData.refreshSuccessResponse
-            verifyZeroInteractions(mockNetworkSessionExpirationListener)
-        }
+        Assertions.assertEquals("PUT", refreshRequest.method)
+        Assertions.assertEquals(
+            "/login/${ContentData.loginSuccessResponse.refreshToken}",
+            refreshRequest.path
+        )
+        Assertions.assertEquals(null, refreshRequest.getHeader("Authorization"))
+        Assertions.assertEquals("Android", refreshRequest.getHeader("Platform"))
+        Assertions.assertEquals("", refreshRequest.body.readUtf8())
+        Assertions.assertEquals(
+            ContentData.refreshSuccessResponse.accessToken,
+            retryAfterTokenRefreshRequest.getHeader("Authorization")
+        )
+        verify(mockNetworkSessionLocalStorage, times(1)).session =
+            ContentData.refreshSuccessResponse
+        verifyZeroInteractions(mockNetworkSessionExpirationListener)
+    }
 
     @DisplayName("GIVEN 401 THEN failing refresh WHEN content requested THE error is returned and callback is Called")
     @Test