From 49b7b630f06ca91806b6fc73255a7a1b9c7cfdcc Mon Sep 17 00:00:00 2001 From: Gergely Hegedus Date: Wed, 18 Jan 2023 12:15:05 +0200 Subject: [PATCH] PR#143 Fix lint warnings --- app/src/main/res/values-night/themes.xml | 2 +- app/src/main/res/values/themes.xml | 2 +- hilt/hilt-app/src/main/res/values-night/themes.xml | 2 +- hilt/hilt-app/src/main/res/values/themes.xml | 2 +- .../idlingresources/OkHttp3IdlingResource.kt | 6 +----- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/app/src/main/res/values-night/themes.xml b/app/src/main/res/values-night/themes.xml index 4e197d3..c3400cc 100644 --- a/app/src/main/res/values-night/themes.xml +++ b/app/src/main/res/values-night/themes.xml @@ -10,7 +10,7 @@ @color/teal_200 @color/black - ?attr/colorPrimaryVariant + ?attr/colorPrimaryVariant \ No newline at end of file diff --git a/app/src/main/res/values/themes.xml b/app/src/main/res/values/themes.xml index 64b01cd..3255b93 100644 --- a/app/src/main/res/values/themes.xml +++ b/app/src/main/res/values/themes.xml @@ -10,7 +10,7 @@ @color/teal_700 @color/black - ?attr/colorPrimaryVariant + ?attr/colorPrimaryVariant \ No newline at end of file diff --git a/hilt/hilt-app/src/main/res/values-night/themes.xml b/hilt/hilt-app/src/main/res/values-night/themes.xml index 4e197d3..c3400cc 100644 --- a/hilt/hilt-app/src/main/res/values-night/themes.xml +++ b/hilt/hilt-app/src/main/res/values-night/themes.xml @@ -10,7 +10,7 @@ @color/teal_200 @color/black - ?attr/colorPrimaryVariant + ?attr/colorPrimaryVariant \ No newline at end of file diff --git a/hilt/hilt-app/src/main/res/values/themes.xml b/hilt/hilt-app/src/main/res/values/themes.xml index 64b01cd..3255b93 100644 --- a/hilt/hilt-app/src/main/res/values/themes.xml +++ b/hilt/hilt-app/src/main/res/values/themes.xml @@ -10,7 +10,7 @@ @color/teal_700 @color/black - ?attr/colorPrimaryVariant + ?attr/colorPrimaryVariant \ No newline at end of file diff --git a/test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/synchronization/idlingresources/OkHttp3IdlingResource.kt b/test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/synchronization/idlingresources/OkHttp3IdlingResource.kt index 258067b..f1cf274 100644 --- a/test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/synchronization/idlingresources/OkHttp3IdlingResource.kt +++ b/test-util-android/src/main/java/org/fnives/test/showcase/android/testutil/synchronization/idlingresources/OkHttp3IdlingResource.kt @@ -1,7 +1,6 @@ package org.fnives.test.showcase.android.testutil.synchronization.idlingresources import androidx.annotation.CheckResult -import androidx.annotation.NonNull import androidx.test.espresso.IdlingResource import okhttp3.Dispatcher import okhttp3.OkHttpClient @@ -55,10 +54,7 @@ class OkHttp3IdlingResource private constructor( * this instance using `Espresso.registerIdlingResources`. */ @CheckResult - @NonNull - fun create(@NonNull name: String?, @NonNull client: OkHttpClient?): OkHttp3IdlingResource { - if (name == null) throw NullPointerException("name == null") - if (client == null) throw NullPointerException("client == null") + fun create(name: String, client: OkHttpClient): OkHttp3IdlingResource { return OkHttp3IdlingResource(name, client.dispatcher) }