diff --git a/.github/workflows/deploy_to_firebase.yml b/.github/workflows/deploy_to_firebase.yml index cd9076d..d0c74f1 100644 --- a/.github/workflows/deploy_to_firebase.yml +++ b/.github/workflows/deploy_to_firebase.yml @@ -2,6 +2,10 @@ name: Deploy to Firebase on: workflow_dispatch: + inputs: + releaseNotes: + description: 'Release Notes attached to Firebase Build (defaults to last commit hash+message if left empty)' + type: string jobs: android-publish-to-firebase: @@ -49,7 +53,7 @@ jobs: - name: Deploy to Firebase working-directory: ./android - run: bundle exec fastlane deployInternalToFirebase + run: bundle exec fastlane deployInternalToFirebase release_notes:"${{ github.event.inputs.releaseNotes }}" ios-publish-to-firebase: runs-on: macos-latest @@ -116,4 +120,4 @@ jobs: CI_EVAL_IOS_CERT_PASSWORD: ${{ secrets.CI_EVAL_IOS_CERT_PASSWORD }} CI_EVAL_INTERNAL_APP_IDENTIFIER: ${{ secrets.CI_EVAL_INTERNAL_APP_IDENTIFIER }} working-directory: ./ios - run: bundle exec fastlane deployInternalToFirebase \ No newline at end of file + run: bundle exec fastlane deployInternalToFirebase release_notes:"${{ github.event.inputs.releaseNotes }}" \ No newline at end of file diff --git a/android/fastlane/Fastfile b/android/fastlane/Fastfile index 7e515d8..c7bcfde 100644 --- a/android/fastlane/Fastfile +++ b/android/fastlane/Fastfile @@ -37,7 +37,7 @@ platform :android do desc "```" lane :deployInternalToFirebase do |options| release_notes = options[:release_notes] - if release_notes.nil? + if release_notes.nil? || release_notes.empty? commit = last_git_commit release_notes = "Last commit with hash: #{commit[:commit_hash]} and message: #{commit[:message]}" end diff --git a/android/fastlane/README.md b/android/fastlane/README.md index 67f11df..5a6833f 100644 --- a/android/fastlane/README.md +++ b/android/fastlane/README.md @@ -15,10 +15,10 @@ For _fastlane_ installation instructions, see [Installing _fastlane_](https://do ## Android -### android deployInternalFirebase +### android deployInternalToFirebase ```sh -[bundle exec] fastlane android deployInternalFirebase +[bundle exec] fastlane android deployInternalToFirebase ``` Submit a new Internal Build to Firebase @@ -27,7 +27,7 @@ Submit a new Internal Build to Firebase ```sh -[bundle exec] fastlane deployInternalFirebase release_notes:"testing notes" +[bundle exec] fastlane deployInternalToFirebase release_notes:"testing notes" ``` @@ -41,21 +41,21 @@ Create new Release APK Find it under app/build/outputs/apk/release -### android deployProdPlayStore +### android deployProdToPlayStore ```sh -[bundle exec] fastlane android deployProdPlayStore +[bundle exec] fastlane android deployProdToPlayStore ``` Submit a new Production Build to Play Store -By Default it sets the version_code to last from Playstore + 1. +By Default it sets the version_code to last from PlayStore + 1. >Optionally version code increase can be skipped via: ```sh -[bundle exec] fastlane deployInternalFirebase skip_build_number_increase:1 +[bundle exec] fastlane deployProdToPlayStore skip_build_number_increase:1 ``` diff --git a/ios/fastlane/Fastfile b/ios/fastlane/Fastfile index 2d7e269..927f5c5 100644 --- a/ios/fastlane/Fastfile +++ b/ios/fastlane/Fastfile @@ -54,7 +54,7 @@ platform :ios do desc "```" lane :deployInternalToFirebase do |options| release_notes = options[:release_notes] - if release_notes.nil? + if release_notes.nil? || release_notes.empty? commit = last_git_commit release_notes = "Last commit with hash: #{commit[:commit_hash]} and message: #{commit[:message]}" end diff --git a/ios/fastlane/README.md b/ios/fastlane/README.md index bf3f81b..1fb35b7 100644 --- a/ios/fastlane/README.md +++ b/ios/fastlane/README.md @@ -15,10 +15,10 @@ For _fastlane_ installation instructions, see [Installing _fastlane_](https://do ## iOS -### ios deployInternalFirebase +### ios deployInternalToFirebase ```sh -[bundle exec] fastlane ios deployInternalFirebase +[bundle exec] fastlane ios deployInternalToFirebase ``` Creates Release Signed build and publishes it to firebase @@ -27,7 +27,7 @@ Creates Release Signed build and publishes it to firebase ```sh -[bundle exec] fastlane deployInternalFirebase release_notes:"testing notes" +[bundle exec] fastlane deployInternalToFirebase release_notes:"testing notes" ```